feat: Get the EVM address for a given Farcaster User #114
Conversation
|
@Sneh1999 can you share where in the Farcaster spec those are specified. Also how they are used. In particular I am curios to understand from where the Request is coming from. |
I found this about verifications in the protocol docs Custody address is used to check if a given message is valid or not. A FID is connected to a custody address. Verified address on the other hand can be multiple like |
Sneh1999
changed the title
| fid: number, | ||
| options?: GetFarcasterUserAddressOptions, | ||
| ): Promise<GetFarcasterUserAddressResponse | null> { | ||
| try { |
There was a problem hiding this comment.
@Sneh1999 side not for the next PR, large try/catch are a bad practice in Javascript, as each Try/Catch will hold on memory almost everything inside a try till the end of the execution. It's advice to have smaller try/catch.
| options?: GetFarcasterUserAddressOptions, | ||
| ): Promise<GetFarcasterUserAddressResponse | null> { | ||
| try { | ||
| const hasCustodyAddresses = options?.hasCustodyAddresses ?? true; |
There was a problem hiding this comment.
hasCustodyAddresses @Sneh1999 did you mentioned there can be only one address for custody?
There was a problem hiding this comment.
So why not hasCustodyAddress as singular?
What changed? Why?
Ability to extract the EVM address for a given Farcaster user
It gives the client ability to either get the verified address or the custody address
Notes to reviewers
How has it been tested?
yarn testyarn integration:test